linux-kernel - Re: [PATCH v1] hid-playstation: DS4: Update rumble and lightbar together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf096319-c44d-4bbf-bbcb-374d3cce0ca7@enpas.org>
Date: Mon, 22 Jul 2024 12:40:38 +0900
From: Max Staudt <max@...as.org>
To: Roderick Colenbrander <thunderbird2k@...il.com>,
 Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: Roderick Colenbrander <roderick.colenbrander@...y.com>,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] hid-playstation: DS4: Update rumble and lightbar
 together

On second thought, maybe we can sidestep this discussion entirely by 
using a new Kconfig to have both states configurable.

Something like:

   CONFIG_HID_PLAYSTATION_V6_6_ANDROID_TEST_COMPAT

Improvements such as my patch would be turned off when this flag is 
enabled, and the driver behaviour reverted to the v6.6 LTS behaviour. So 
Android kernels would enable it, and everyone else (especially desktop 
distributions) can leave it off.

Then, once the Android test suite is fixed, the Kconfig can be removed. 
Looking at the Android release cadence in recent years, and the timeline 
of DS4 support in hid-playstation and in the v6.6 LTS kernel, I presume 
this would be in 1-2 years.

This way, upstream can continue improving the driver, without triggering 
Android test failures.

How does this sound?

Max