linux-kernel - Re: [PATCH v2] spi: ppc4xx: handle irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6234dbfd-c153-4f67-a828-342919d41de6@sirena.org.uk>
Date: Mon, 22 Jul 2024 14:40:15 +0100
From: Mark Brown <broonie@...nel.org>
To: Ma Ke <make24@...as.ac.cn>
Cc: sfalco@...ris.com, sr@...x.de, dbrownell@...rs.sourceforge.net,
	jwboyer@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] spi: ppc4xx: handle irq_of_parse_and_map() errors

On Mon, Jul 22, 2024 at 08:35:19PM +0800, Ma Ke wrote:
> Zero and negative number is not a valid IRQ for in-kernel code and the
> irq_of_parse_and_map() function returns zero on error.  So this check for
> valid IRQs should only accept values > 0.
> 
> Cc: stable@...r.kernel.org
> Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
> Changes in v2:
> - added Cc stable line;
> - added Fixes line.

The Cc stable seems clearly disproportionate here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)