linux-kernel - Re: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2dffc5d-9598-4722-8a24-8ad113c9321a@kernel.org>
Date: Mon, 22 Jul 2024 16:07:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kousik Sanagavarapu <five231003@...il.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Guenter Roeck <linux@...ck-us.net>, Nishanth Menon <nm@...com>,
 Santosh Shilimkar <ssantosh@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-watchdog@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog
 nodenames

On 22/07/2024 15:21, Kousik Sanagavarapu wrote:
> On Mon, Jul 22, 2024 at 10:13:59AM +0200, Krzysztof Kozlowski wrote:
>> On 21/07/2024 18:28, Kousik Sanagavarapu wrote:
>>> Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow
>>> for validation with the corresponding dtschema and gives errors
>>>
>>> [...]
>>>
>> That's entirely unrelated patch. Don't mix simple cleanups with patches
>> affecting ABI and users. Also, explain why.
> 
> Got it.  Will submit v2 as a seperate patch, outside of this series.

... and carefully re-think why. I am 99% sure your patch breaks the
users. Better if you test your changes.

Conversion of the bindings is a task which requires to know how DTS works.

Best regards,
Krzysztof