linux-kernel - Re: [PATCH 1/1] lib/llist_kunit.c: add KUnit tests for llist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1a7c02f-2a13-4319-be33-fc7f613b7e8a@quicinc.com>
Date: Mon, 22 Jul 2024 07:16:17 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Artur Alves <arturacb@...il.com>,
        Andrew Morton
	<akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>,
        Brendan Higgins
	<brendan.higgins@...ux.dev>,
        David Gow <davidgow@...gle.com>, Rae Moar
	<rmoar@...gle.com>,
        <linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>
CC: <n@...aprado.net>, <andrealmeid@...eup.net>, <vinicius@...elet.com>,
        <diego.daniel.professional@...il.com>
Subject: Re: [PATCH 1/1] lib/llist_kunit.c: add KUnit tests for llist

On 7/21/24 16:43, Artur Alves wrote:
> Add KUnit tests for the llist data structure. They test the vast
> majority of methods and macros defined in include/linux/llist.h.
> 
> These are inspired by the existing tests for the 'list' doubly
> linked in lib/list-test.c [1]. Each test case (llist_test_x)
> tests the behaviour of the llist function/macro 'x'.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/list-test.c
> 
> Signed-off-by: Artur Alves <arturacb@...il.com>
> ---
>   lib/Kconfig.debug |  11 ++
>   lib/Makefile      |   1 +
>   lib/llist_kunit.c | 360 ++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 372 insertions(+)
>   create mode 100644 lib/llist_kunit.c

...

> +MODULE_LICENSE("GPL v2");

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the 
description is missing") a module without a MODULE_DESCRIPTION() will 
result in a warning with make W=1.

Multiple developers, including myself, have been fixing the existing 
warnings for 6.11 so please don't introduce a new one :)

/jeff