linux-kernel - Re: [PATCH v1 3/6] perf auxtrace s390: Set the 'auxtrace' flag for AUX events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8df1a663-1720-4ee6-9097-b0d6e05beb0e@arm.com>
Date: Mon, 22 Jul 2024 15:48:38 +0100
From: Leo Yan <leo.yan@....com>
To: Adrian Hunter <adrian.hunter@...el.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>,
 James Clark <james.clark@...aro.org>,
 Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach
 <mike.leach@...aro.org>, John Garry <john.g.garry@...cle.com>,
 Will Deacon <will@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
 Mark Rutland <mark.rutland@....com>, coresight@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/6] perf auxtrace s390: Set the 'auxtrace' flag for
 AUX events



On 7/22/24 11:54, Adrian Hunter wrote:

[...]

> On 21/07/24 23:21, Leo Yan wrote:
>> Set the 'auxtrace' flag for AUX events on s390.
>>
>> Signed-off-by: Leo Yan <leo.yan@....com>
>> ---
>>   tools/perf/arch/s390/util/auxtrace.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c
>> index 5068baa3e092..d7e72413b262 100644
>> --- a/tools/perf/arch/s390/util/auxtrace.c
>> +++ b/tools/perf/arch/s390/util/auxtrace.c
>> @@ -99,6 +99,7 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,
>>                if (pos->core.attr.config == PERF_EVENT_CPUM_SF_DIAG) {
>>                        diagnose = 1;
>>                        pos->needs_auxtrace_mmap = true;
>> +                     pos->pmu->auxtrace = true;
> 
> This is probably too late. See:
> 
> https://lore.kernel.org/all/20240715160712.127117-7-adrian.hunter@intel.com/

Okay, I will drop this patch.

Thanks,
Leo


> 
>>                        break;
>>                }
>>        }
>