linux-kernel - Re: [PATCH] cpufreq: powerpc: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f57a034-71fb-4b6a-a718-3dd323d72f7a@quicinc.com>
Date: Mon, 22 Jul 2024 08:23:33 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Michael Ellerman <mpe@...erman.id.au>,
        "Rafael J. Wysocki"
	<rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Nicholas Piggin
	<npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        "Naveen
 N. Rao" <naveen.n.rao@...ux.ibm.com>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros

On 7/22/2024 12:13 AM, Michael Ellerman wrote:
> Jeff Johnson <quic_jjohnson@...cinc.com> writes:
>> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
>> files which have a MODULE_LICENSE().
>>
>> This includes three additional files which, although they did not
>> produce a warning with the powerpc allmodconfig configuration, may
>> cause this warning with specific options enabled in the kernel
>> configuration.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>> Corrections to these descriptions are welcomed. I'm not an expert in
>> this code so in most cases I've taken these descriptions directly from
>> code comments, Kconfig descriptions, or git logs.  History has shown
>> that in some cases these are originally wrong due to cut-n-paste
>> errors, and in other cases the drivers have evolved such that the
>> original information is no longer accurate.
>> ---
>>  drivers/cpufreq/maple-cpufreq.c   | 1 +
>>  drivers/cpufreq/pasemi-cpufreq.c  | 1 +
>>  drivers/cpufreq/pmac64-cpufreq.c  | 1 +
>>  drivers/cpufreq/powernv-cpufreq.c | 1 +
>>  drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
>>  5 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
>> index f9306410a07f..19ca7f874d28 100644
>> --- a/drivers/cpufreq/maple-cpufreq.c
>> +++ b/drivers/cpufreq/maple-cpufreq.c
>> @@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
>>  module_init(maple_cpufreq_init);
>>  
>>  
>> +MODULE_DESCRIPTION("cpufreq driver for Maple 970FX Evaluation Board");
>  
> Can you change this one to:
> 
> "cpufreq driver for Maple 970FX/970MP boards");
> 
> It looks for both those CPUs in probe.
> 
>> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
>> index fddbd1ea1635..e923f717e1d7 100644
>> --- a/drivers/cpufreq/powernv-cpufreq.c
>> +++ b/drivers/cpufreq/powernv-cpufreq.c
>> @@ -1162,5 +1162,6 @@ static void __exit powernv_cpufreq_exit(void)
>>  }
>>  module_exit(powernv_cpufreq_exit);
>>  
>> +MODULE_DESCRIPTION("cpufreq driver for the IBM POWER processors");
> 
> This one's tricky, because it probes based on the device tree, though it
> is restricted to CONFIG_POWERNV. It also supports non-IBM CPUs in theory
> at least. Maybe something like:
> 
> "cpufreq driver for IBM/OpenPOWER powernv systems");
> 
> cheers
Sure, I'll send an update shortly.

/jeff