linux-kernel - Re: [PATCH] mtd: mtdoops: Fix kmsgdump parameter renaming.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1868573045.102281.1721661681881.JavaMail.zimbra@nod.at>
Date: Mon, 22 Jul 2024 17:21:21 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Jocelyn Falempe <jfalempe@...hat.com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Vignesh Raghavendra <vigneshr@...com>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	DRI mailing list <dri-devel@...ts.freedesktop.org>, 
	Knop Ryszard <ryszard.knop@...el.com>
Subject: Re: [PATCH] mtd: mtdoops: Fix kmsgdump parameter renaming.

----- Ursprüngliche Mail -----
> Betreff: [PATCH] mtd: mtdoops: Fix kmsgdump parameter renaming.

> When the kmsg_dumper callback parameter changed, the reason variable
> in mtdoops_do_dump() was not updated accordingly.
> This breaks the build with mtdoops.
> 
> Fixes: e1a261ba599e ("printk: Add a short description string to kmsg_dump()")
> Reported-by: Knop Ryszard <ryszard.knop@...el.com>
> Signed-off-by: Jocelyn Falempe <jfalempe@...hat.com>
> ---
> 
> The offended commit is in the drm-misc tree, because it was needed
> by drm_panic. So I will push the fix there too.
> 
> drivers/mtd/mtdoops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
> index 86d49db9196d..7bf3777e1f13 100644
> --- a/drivers/mtd/mtdoops.c
> +++ b/drivers/mtd/mtdoops.c
> @@ -305,7 +305,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
> 	struct kmsg_dump_iter iter;
> 
> 	/* Only dump oopses if dump_oops is set */
> -	if (reason == KMSG_DUMP_OOPS && !dump_oops)
> +	if (detail->reason == KMSG_DUMP_OOPS && !dump_oops)
> 		return;
> 
> 	kmsg_dump_rewind(&iter);
> @@ -317,7 +317,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
> 			     record_size - sizeof(struct mtdoops_hdr), NULL);
> 	clear_bit(0, &cxt->oops_buf_busy);
> 
> -	if (reason != KMSG_DUMP_OOPS) {
> +	if (detail->reason != KMSG_DUMP_OOPS) {

Acked-by: Richard Weinberger <richard@....at>

Thanks,
//richard