linux-kernel - Re: [PATCH v3] spi: ppc4xx: handle irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bceb4055-e315-4c70-a682-228cb997f86c@web.de>
Date: Mon, 22 Jul 2024 17:42:23 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, linux-spi@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 David Brownell <dbrownell@...rs.sourceforge.net>,
 Josh Boyer <jwboyer@...ux.vnet.ibm.com>, Mark Brown <broonie@...nel.org>,
 Stefan Roese <sr@...x.de>, "Steven A. Falco" <sfalco@...ris.com>
Subject: Re: [PATCH v3] spi: ppc4xx: handle irq_of_parse_and_map() errors

…
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

Will any contributors care more for rules also according to such information?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n398
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/researcher-guidelines.rst?h=v6.10#n5

…
> +++ b/drivers/spi/spi-ppc4xx.c
> @@ -416,6 +416,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
>  	if (hw->irqnum <= 0)
>  		goto free_host;
>
> +	if (hw->irqnum <= 0)
> +		goto free_host;
…

Why do you propose anyhow to add duplicate source code here?

Regards,
Markus