linux-kernel - Re: [PATCH v3 2/2] dma: add IOMMU static calls with clear default ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240722154458.GA7022@unreal>
Date: Mon, 22 Jul 2024 18:44:58 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Easwar Hariharan <eahariha@...ux.microsoft.com>,
	linux-kernel@...r.kernel.org, iommu@...ts.linux.dev,
	Jason Gunthorpe <jgg@...dia.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 2/2] dma: add IOMMU static calls with clear default ops

On Mon, Jul 22, 2024 at 05:10:37PM +0200, Christoph Hellwig wrote:
> On Sun, Jul 21, 2024 at 10:49:11AM +0300, Leon Romanovsky wrote:
> > -static void iommu_dma_free_noncontiguous(struct device *dev, size_t size,
> > -		struct sg_table *sgt, enum dma_data_direction dir)
> > +void iommu_dma_free_noncontiguous(struct device *dev, size_t size,
> > +				  struct sg_table *sgt,
> > +				  enum dma_data_direction dir)
> 
> Why are you reformatting these to a much less readable coding style?

I'm relying on clang-formatter to format the code, see .clang-format
file in the kernel root directory.

> 
> > +static inline struct page *
> > +dma_common_alloc_pages(struct device *dev, size_t size, dma_addr_t *dma_handle,
> > +		       enum dma_data_direction dir, gfp_t gfp)
> > +{
> > +	return NULL;
> > +}
> > +static inline void dma_common_free_pages(struct device *dev, size_t size,
> > +					 struct page *vaddr,
> > +					 dma_addr_t dma_handle,
> > +					 enum dma_data_direction dir)
> > +{
> > +}
> 
> dma-iommu very much depends on these.  So we'll need to also
> build ops_helpers.o if dma-iommu is enabled.  So we'll probably need
> a separate Kconfig option for it that the various users select.
> 

I removed them from dma-iommu.c and there are no calls to them in that file.
➜  kernel git:(m/dma-v2) git grep dma_common_alloc_pages drivers/iommu/ | wc -l
0

Thanks