linux-kernel - Re: [PATCH] media: raspberrypi: VIDEO_RASPBERRYPI_PISP_BE should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ol5jiqwo26s6nrl3a3x4qcs7etxkbzbaz24lah2vgdsfj7qifr@5wnrk3tjr6n4>
Date: Mon, 22 Jul 2024 17:59:46 +0200
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Nick Hollinghurst <nick.hollinghurst@...pberrypi.org>, Naushir Patuck <naush@...pberrypi.com>, 
	Hans Verkuil <hverkuil-cisco@...all.nl>, David Plowman <david.plowman@...pberrypi.com>, 
	linux-media@...r.kernel.org, kernel-list@...pberrypi.com, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: raspberrypi: VIDEO_RASPBERRYPI_PISP_BE should
 depend on ARCH_BCM2835

Hi Geert

On Mon, Jul 22, 2024 at 05:28:28PM GMT, Geert Uytterhoeven wrote:
> Currently, the Raspberry Pi PiSP Backend (BE) ISP is only present on the
> Broadcom BCM2712-based Raspberry Pi 5.  Hence add a dependency on
                                        ^ nit: double space

> ARCH_BCM2835, to prevent asking the user about this driver when
> configuring a kernel without Broadcom BCM2835 family support.  The

double space before "The" as well

> dependency can be relaxed if/when the encoder appears on other SoC
> families.

we can surely lift this requirement in the unlikely event this happens

Thanks
Acked-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

>
> Fixes: 12187bd5d4f8c128 ("media: raspberrypi: Add support for PiSP BE")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/media/platform/raspberrypi/pisp_be/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> index 38c0f8305d620d83..46765a2e4c4d1573 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig
> @@ -2,6 +2,7 @@ config VIDEO_RASPBERRYPI_PISP_BE
>  	tristate "Raspberry Pi PiSP Backend (BE) ISP driver"
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on VIDEO_DEV
> +	depends on ARCH_BCM2835 || COMPILE_TEST
>  	select VIDEO_V4L2_SUBDEV_API
>  	select MEDIA_CONTROLLER
>  	select VIDEOBUF2_DMA_CONTIG
> --
> 2.34.1
>