linux-kernel - Re: [PATCH v2] cache: StarFive: Require a 64-bit system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJM55Z-hit+-M9qixV4FnOO-i2BsKN56QXK=LkC0FCWzSBptMw@mail.gmail.com>
Date: Mon, 22 Jul 2024 17:59:40 +0200
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Palmer Dabbelt <palmer@...osinc.com>
Cc: Conor Dooley <conor@...nel.org>, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v2] cache: StarFive: Require a 64-bit system

On Mon, 22 Jul 2024 at 17:47, Palmer Dabbelt <palmer@...osinc.com> wrote:
>
> From: Palmer Dabbelt <palmer@...osinc.com>
>
> This has a bunch of {read,write}q() calls, so it won't work on 32-bit
> systems.  I don't think there's any 32-bit StarFive systems, so for now
> just require 64-bit.
>
> Fixes: cabff60ca77d ("cache: Add StarFive StarLink cache management")
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Palmer Dabbelt <palmer@...osinc.com>

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>

> ---
> Changes since v1 <20240719163841.19018-1-palmer@...osinc.com>:
>
> * Drop the STARLINK_CACHE_ADDRESS_RANGE_MASK chunk, it's meaningless
>   without 32-bit support (as Emil pointed out on IRC).
> ---
>  drivers/cache/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cache/Kconfig b/drivers/cache/Kconfig
> index 94abd8f632a7..db51386c663a 100644
> --- a/drivers/cache/Kconfig
> +++ b/drivers/cache/Kconfig
> @@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE
>         bool "StarFive StarLink Cache controller"
>         depends on RISCV
>         depends on ARCH_STARFIVE
> +       depends on 64BIT
>         select RISCV_DMA_NONCOHERENT
>         select RISCV_NONSTANDARD_CACHE_OPS
>         help
> --
> 2.45.2
>