[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240722-displace-amusable-a884352e0ff9@spud>
Date: Mon, 22 Jul 2024 17:37:14 +0100
From: Conor Dooley <conor@...nel.org>
To: Richard Zhu <hongxing.zhu@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
shawnguo@...nel.org, l.stach@...gutronix.de,
devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel@...gutronix.de, imx@...ts.linux.dev
Subject: Re: [PATCH v1 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
"atu" for i.MX8M PCIe Endpoint
On Mon, Jul 22, 2024 at 03:56:16PM +0800, Richard Zhu wrote:
> Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> ---
> .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> index a06f75df8458..309e8953dc91 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> @@ -65,11 +65,13 @@ allOf:
> then:
> properties:
> reg:
> - minItems: 2
> - maxItems: 2
> + minItems: 4
> + maxItems: 4
> reg-names:
> items:
> - const: dbi
> + - const: dbi2
> + - const: atu
New properties in the middle of the list is potentially an ABI break.
Why not add them at the end?
> - const: addr_space
>
> - if:
> @@ -129,8 +131,11 @@ examples:
>
> pcie_ep: pcie-ep@...00000 {
> compatible = "fsl,imx8mp-pcie-ep";
> - reg = <0x33800000 0x000400000>, <0x18000000 0x08000000>;
> - reg-names = "dbi", "addr_space";
> + reg = <0x33800000 0x100000>,
> + <0x33900000 0x100000>,
> + <0x33b00000 0x100000>,
> + <0x18000000 0x8000000>;
> + reg-names = "dbi", "dbi2", "atu", "addr_space";
> clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> <&clk IMX8MP_CLK_HSIO_AXI>,
> <&clk IMX8MP_CLK_PCIE_ROOT>;
> --
> 2.37.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists