linux-kernel - Re: [PATCH 04/10] accel/amdxdna: Add hardware context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b936661-9608-bfce-d7e4-f03cf4538780@amd.com>
Date: Mon, 22 Jul 2024 09:56:53 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Markus Elfring <Markus.Elfring@....de>, Min Ma <min.ma@....com>,
	<dri-devel@...ts.freedesktop.org>, Oded Gabbay <ogabbay@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Max Zhen <max.zhen@....com>, "Sonal
 Santan" <sonal.santan@....com>
Subject: Re: [PATCH 04/10] accel/amdxdna: Add hardware context


On 7/20/24 03:54, Markus Elfring wrote:
>>                                          … The tile columns belong to
> …
>                                                               which …?
>
>
> …
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -0,0 +1,181 @@
> …
>> +void aie2_hwctx_fini(struct amdxdna_hwctx *hwctx)
>> +{
>> +	struct amdxdna_dev *xdna;
>> +
>> +	xdna = hwctx->client->xdna;
> …
>> +}
> …
>
> Please omit such an unused local variable.

Ok. It is used in one of the following patch. I will move this line to 
that patch.


Thanks,

Lizhi

>
> Regards,
> Markus