linux-kernel - Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b4feef7-35c3-4afd-aa08-73871b404835@csgroup.eu>
Date: Mon, 22 Jul 2024 19:14:05 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Michael Ellerman <mpe@...erman.id.au>,
 "Dr. David Alan Gilbert" <linux@...blig.org>,
 Sean Anderson <sean.anderson@...ux.dev>,
 Christophe Leroy <christophe.leroy@...roup.eu>
Cc: camelia.groza@....com, linuxppc-dev@...ts.ozlabs.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'



Le 22/07/2024 à 09:24, Michael Ellerman a écrit :
> "Dr. David Alan Gilbert" <linux@...blig.org> writes:
>> * Sean Anderson (sean.anderson@...ux.dev) wrote:
>>> On 5/28/24 19:11, linux@...blig.org wrote:
>>>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>>>
>>>> 'cgr_comp' has been unused since
>>>> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>>>> qman_delete_cgr_safe()").
>>>>
>>>> Remove it.
>>>>
>>>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>>>> ---
>>>>   drivers/soc/fsl/qbman/qman.c | 5 -----
>>>>   1 file changed, 5 deletions(-)
>>>>
>>>> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>>>> index 7e9074519ad2..4dc8aba33d9b 100644
>>>> --- a/drivers/soc/fsl/qbman/qman.c
>>>> +++ b/drivers/soc/fsl/qbman/qman.c
>>>> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>>>>   }
>>>>   EXPORT_SYMBOL(qman_delete_cgr);
>>>>   
>>>> -struct cgr_comp {
>>>> -	struct qman_cgr *cgr;
>>>> -	struct completion completion;
>>>> -};
>>>> -
>>>>   static void qman_delete_cgr_smp_call(void *p)
>>>>   {
>>>>   	qman_delete_cgr((struct qman_cgr *)p);
>>>
>>> Reviewed-by: Sean Anderson <sean.anderson@...ux.dev>
>>
>> Hi Sean,
>>    Do you know who will pick this one up?
>>    I got a notification a while ago from a patchwork at
>>    linuxppc-dev marked 'Handled elsewhere' - but I'm not
>> sure where.
> 
> drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
> look after it.
> 
> This patch looks trivial so I can just pick it up if you like Christophe?
> 

Sure Michael, you can pick it up.

Thanks
Christophe