[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0fe1b57e-4557-4020-878a-7eec13a2fdb1@linuxfoundation.org>
Date: Mon, 22 Jul 2024 11:32:35 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Laura Nao <laura.nao@...labora.com>, shuah@...nel.org
Cc: gregkh@...uxfoundation.org, nfraprado@...labora.com,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...labora.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: ksft: Track skipped tests when finishing the
test suite
On 7/22/24 09:43, Laura Nao wrote:
> Consider skipped tests in addition to passed tests when evaluating the
> overall result of the test suite in the finished() helper.
>
> Signed-off-by: Laura Nao <laura.nao@...labora.com>
> ---
> tools/testing/selftests/kselftest/ksft.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest/ksft.py b/tools/testing/selftests/kselftest/ksft.py
> index cd89fb2bc10e..bf215790a89d 100644
> --- a/tools/testing/selftests/kselftest/ksft.py
> +++ b/tools/testing/selftests/kselftest/ksft.py
> @@ -70,7 +70,7 @@ def test_result(condition, description=""):
>
>
> def finished():
> - if ksft_cnt["pass"] == ksft_num_tests:
> + if ksft_cnt["pass"] + ksft_cnt["skip"] == ksft_num_tests:
Please don't. Counting skips in pass or fail isn't accurate
reporting. skips need to be reported as skips.
thanks,
-- Shuah
Powered by blists - more mailing lists