linux-kernel - Re: [PATCH] scsi: ufs: core: Do not set link to OFF state while waking up from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54704229-221f-4724-b386-48c39ee1290c@acm.org>
Date: Mon, 22 Jul 2024 10:57:30 -0700
From: Bart Van Assche <bvanassche@....org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 James.Bottomley@...senPartnership.com, martin.petersen@...cle.com
Cc: alim.akhtar@...sung.com, avri.altman@....com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, Anjana Hari <quic_ahari@...cinc.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Do not set link to OFF state while
 waking up from hibernation

On 7/18/24 10:06 AM, Manivannan Sadhasivam wrote:
> UFS link is just put into hibern8 state during the 'freeze' process of the
> hibernation. Afterwards, the system may get powered down. But that doesn't
> matter during wakeup. Because during wakeup from hibernation, UFS link is
> again put into hibern8 state by the restore kernel and then the control is
> handed over to the to image kernel.
> 
> So in both the places, UFS link is never turned OFF. But
> ufshcd_system_restore() just assumes that the link will be in OFF state and
> sets the link state accordingly. And this breaks hibernation wakeup:

Reviewed-by: Bart Van Assche <bvanassche@....org>