linux-kernel - Re: [PATCH v2 09/16] xz: Cleanup CRC32 edits from 2018

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed7mvyky.fsf@mail.lhotse>
Date: Mon, 22 Jul 2024 14:29:33 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Lasse Collin <lasse.collin@...aani.org>, Andrew Morton
 <akpm@...ux-foundation.org>
Cc: Lasse Collin <lasse.collin@...aani.org>, Sam James <sam@...too.org>,
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>, Joel Stanley <joel@....id.au>
Subject: Re: [PATCH v2 09/16] xz: Cleanup CRC32 edits from 2018

Lasse Collin <lasse.collin@...aani.org> writes:
> In 2018, a dependency on <linux/crc32poly.h> was added to avoid
> duplicating the same constant in multiple files. Two months later it
> was found to be a bad idea and the definition of CRC32_POLY_LE macro
> was moved into xz_private.h to avoid including <linux/crc32poly.h>.
>
> xz_private.h is a wrong place for it too. Revert back to the upstream
> version which has the poly in xz_crc32_init() in xz_crc32.c.
>
> Fixes: faa16bc404d7 ("lib: Use existing define with polynomial")
> Fixes: 242cdad873a7 ("lib/xz: Put CRC32_POLY_LE in xz_private.h")
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Joel Stanley <joel@....id.au>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Reviewed-by: Sam James <sam@...too.org>
> Signed-off-by: Lasse Collin <lasse.collin@...aani.org>
> ---
>  lib/xz/xz_crc32.c   | 2 +-
>  lib/xz/xz_private.h | 4 ----
>  2 files changed, 1 insertion(+), 5 deletions(-)

Tested-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers