linux-kernel - Re: [PATCH v2] PCI: shpchp: Remove hpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240722195808.GA729979@bhelgaas>
Date: Mon, 22 Jul 2024 14:58:08 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: ngn <ngn@....tf>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: shpchp: Remove hpc_ops

On Mon, Jul 22, 2024 at 02:04:00PM +0300, ngn wrote:
> hpc_ops struct is only used by shpchp, and it's unnecessary. This is
> explained in the TODO file: drivers/pci/hotplug/TODO.

This is a true statement, but it doesn't actually say what the patch
*does* about it.

The subject line does say it, but it should also be in the commit log
itself because the subject is a title, not part of the commit log:

https://chris.beams.io/posts/git-commit/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94

Point to the commit(s) that make similar changes to other drivers.

Please also update the TODO file to remove this item.

> Signed-off-by: ngn <ngn@....tf>
> ---

What's the change from v1?  It can go here (below the "---" cut line),
where it's useful but doesn't get included in the commit log when
merged.

Bjorn