[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240722210507.76d82f54@jic23-huawei>
Date: Mon, 22 Jul 2024 21:05:07 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Matteo Martelli <matteomartelli3@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Marius Cristea <marius.cristea@...rochip.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: iio: adc: add binding for pac1921
On Mon, 22 Jul 2024 12:03:18 +0200
Matteo Martelli <matteomartelli3@...il.com> wrote:
> Add binging for Microchip PAC1921 Power/Current monitor
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Matteo Martelli <matteomartelli3@...il.com>
> ---
> .../bindings/iio/adc/microchip,pac1921.yaml | 71 ++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,pac1921.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,pac1921.yaml
> new file mode 100644
> index 000000000000..b6f01b79b91d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,pac1921.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/microchip,pac1921.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PAC1921 High-Side Power/Current Monitor with Anaog Output
> +
> +maintainers:
> + - Matteo Martelli <matteomartelli3@...il.com>
> +
> +description: |
> + The PAC1921 is a power/current monitoring device with an analog output
> + and I2C/SMBus interface.
> +
> + Datasheet can be found here:
> + https://ww1.microchip.com/downloads/en/DeviceDoc/PAC1921-Data-Sheet-DS20005293E.pdf
> +
> +properties:
> + compatible:
> + const: microchip,pac1921
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> + "#io-channel-cells":
> + const: 1
> +
> + shunt-resistor-micro-ohms:
> + description:
> + Value in micro Ohms of the shunt resistor connected between
> + the SENSE+ and SENSE- inputs, across which the current is measured.
> + Value is needed to compute the scaling of the measured current.
> +
> + label:
> + description: Unique name to identify which device this is.
> +
> + microchip,read-int-gpios:
Given I agree with Conor about not needing a vendor prefix for gpios
so you'll be respinning anyway:
Would you mind renaming this to longer form: read-integrate-gpios?
I was briefly assuming it was a INTerrupt pin.
> + description:
> + READ/INT input pin to control the current state of the device, either in
> + the INTEGRATE state when driven high, or in the READ state when driven low.
> + When not connected the pin is floating and it can be overridden by the
> + INT_EN register bit after asserting the READ/INT_OVR register bit.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> + - shunt-resistor-micro-ohms
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@4c {
> + compatible = "microchip,pac1921";
> + reg = <0x4c>;
> + vdd-supply = <&vdd>;
> + #io-channel-cells = <1>;
> + label = "vbat";
> + shunt-resistor-micro-ohms = <10000>;
> + };
> + };
> +...
>
Powered by blists - more mailing lists