linux-kernel - Re: [PATCH v1] drm/virtio: Fix type of dma-fence context variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGutuf_B7fHH-SzBSWC0=tUbCk2MtRo7qWbvGCrqMVTLYg@mail.gmail.com>
Date: Mon, 22 Jul 2024 17:21:39 -0700
From: Rob Clark <robdclark@...il.com>
To: Dmitry Osipenko <dmitry.osipenko@...labora.com>
Cc: David Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, 
	Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, 
	Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v1] drm/virtio: Fix type of dma-fence context variable

On Sun, Jul 14, 2024 at 1:50 PM Dmitry Osipenko
<dmitry.osipenko@...labora.com> wrote:
>
> Type of DMA fence context is u64. Fence-waiting code uses u32 for the
> context variable, fix it.
>
> Fixes: e4812ab8e6b1 ("drm/virtio: Refactor and optimize job submission code path")
> Cc: <stable@...r.kernel.org> # v6.4+
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/virtio/virtgpu_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c
> index 1c7c7f61a222..7d34cf83f5f2 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c
> @@ -48,7 +48,7 @@ struct virtio_gpu_submit {
>  static int virtio_gpu_do_fence_wait(struct virtio_gpu_submit *submit,
>                                     struct dma_fence *in_fence)
>  {
> -       u32 context = submit->fence_ctx + submit->ring_idx;
> +       u64 context = submit->fence_ctx + submit->ring_idx;
>
>         if (dma_fence_match_context(in_fence, context))
>                 return 0;
> --
> 2.45.2
>