linux-kernel - Re: [PATCH] irqchip/loongarch-cpu: Fix return value of lpic_gsi_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <46775654-4c2c-4048-9f1d-bd464bbca25e@app.fastmail.com>
Date: Tue, 23 Jul 2024 14:46:47 +0800
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Huacai Chen" <chenhuacai@...ngson.cn>,
 "Thomas Gleixner" <tglx@...utronix.de>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
 "Xuefeng Li" <lixuefeng@...ngson.cn>, "Huacai Chen" <chenhuacai@...il.com>,
 "Miao Wang" <shankerwangmiao@...il.com>
Subject: Re: [PATCH] irqchip/loongarch-cpu: Fix return value of lpic_gsi_to_irq()



在2024年7月23日七月 下午2:45，Huacai Chen写道：
> lpic_gsi_to_irq() should return a valid irq if acpi_register_gsi()
> succeed, and return 0 otherwise. But now lpic_gsi_to_irq() converts
> a negative return value of acpi_register_gsi() to a positive value
> silently, so fix it.
>
> Reported-by: Miao Wang <shankerwangmiao@...il.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>

Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>

> ---
>  drivers/irqchip/irq-loongarch-cpu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-loongarch-cpu.c 
> b/drivers/irqchip/irq-loongarch-cpu.c
> index 9d8f2c406043..b35903a06902 100644
> --- a/drivers/irqchip/irq-loongarch-cpu.c
> +++ b/drivers/irqchip/irq-loongarch-cpu.c
> @@ -18,11 +18,13 @@ struct fwnode_handle *cpuintc_handle;
> 
>  static u32 lpic_gsi_to_irq(u32 gsi)
>  {
> +	int irq = 0;
> +
>  	/* Only pch irqdomain transferring is required for LoongArch. */
>  	if (gsi >= GSI_MIN_PCH_IRQ && gsi <= GSI_MAX_PCH_IRQ)
> -		return acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH);
> +		irq = acpi_register_gsi(NULL, gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_HIGH);
> 
> -	return 0;
> +	return (irq > 0) ? irq : 0;
>  }
> 
>  static struct fwnode_handle *lpic_get_gsi_domain_id(u32 gsi)
> -- 
> 2.43.5

-- 
- Jiaxun