linux-kernel - Re: [PATCH 3/4] ASoC: dt-bindings: qcom,sm8250: Add msm8953/msm8976-qdsp6-sndcard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea4436f1-1b85-4083-9807-98e814ba597e@kernel.org>
Date: Tue, 23 Jul 2024 10:36:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Adam Skladowski <a39.skl@...il.com>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Banajit Goswami <bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, linux-arm-msm@...r.kernel.org,
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ASoC: dt-bindings: qcom,sm8250: Add
 msm8953/msm8976-qdsp6-sndcard

On 23/07/2024 10:19, Krzysztof Kozlowski wrote:
> On 22/07/2024 11:51, Adam Skladowski wrote:
>> Document MSM8953/MSM8976 QDSP6 cards.
>>
>> Signed-off-by: Adam Skladowski <a39.skl@...il.com>
> 
> ...
> 
>> +    then:
>>        properties:
>> -        reg: false
>> -        reg-names: false
>> +        reg:
>> +          items:
>> +            - description: Microphone I/O mux register address
>> +            - description: Speaker I/O mux register address
>> +            - description: Quinary Mi2S I/O mux register address
>> +        reg-names:
>> +          items:
>> +            - const: mic-iomux
>> +            - const: spkr-iomux
>> +            - const: quin-iomux
>> +      required:
>> +        - compatible
>> +        - model
> 
> Don't duplicate. It's already required.

I suggest to rebase on top of my patch. Optionally, take it into your
patchset.

Best regards,
Krzysztof