linux-kernel - Re: [RFC PATCH v3 17/37] kvx: Add boot and setup routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d9e8ac6a-23b7-4f9e-b096-2212b9899c4f@app.fastmail.com>
Date: Tue, 23 Jul 2024 08:44:00 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Yann Sionneau" <ysionneau@...rayinc.com>, linux-kernel@...r.kernel.org
Cc: "Jonathan Borne" <jborne@...rayinc.com>,
 "Julian Vetter" <jvetter@...rayinc.com>,
 "Alex Michon" <amichon@...rayinc.com>,
 "Clement Leger" <clement@...ment-leger.fr>,
 "Guillaume Missonnier" <gmissonnier@...rayinc.com>,
 "Guillaume Thouvenin" <thouveng@...il.com>,
 "Jules Maselbas" <jmaselbas@...v.net>,
 "Julien Hascoet" <jhascoet@...rayinc.com>,
 "Julien Villette" <julien.villette@...il.com>,
 Marc Poulhiès <dkm@...aplop.net>,
 "Luc Michel" <luc@...chel.fr>, "Marius Gligor" <mgligor@...rayinc.com>
Subject: Re: [RFC PATCH v3 17/37] kvx: Add boot and setup routines

On Mon, Jul 22, 2024, at 09:41, ysionneau@...rayinc.com wrote:
> From: Yann Sionneau <ysionneau@...rayinc.com>
>
> Add basic boot, setup and reset routines for kvx.
> ---
>  arch/kvx/include/asm/setup.h |  34 ++
>  arch/kvx/kernel/common.c     |  11 +
>  arch/kvx/kernel/head.S       | 580 +++++++++++++++++++++++++++++++++++
>  arch/kvx/kernel/prom.c       |  26 ++
>  arch/kvx/kernel/reset.c      |  37 +++
>  arch/kvx/kernel/setup.c      | 181 +++++++++++
>  arch/kvx/kernel/time.c       | 242 +++++++++++++++
>  7 files changed, 1111 insertions(+)
>  create mode 100644 arch/kvx/include/asm/setup.h
>  create mode 100644 arch/kvx/kernel/common.c
>  create mode 100644 arch/kvx/kernel/head.S
>  create mode 100644 arch/kvx/kernel/prom.c
>  create mode 100644 arch/kvx/kernel/reset.c
>  create mode 100644 arch/kvx/kernel/setup.c
>  create mode 100644 arch/kvx/kernel/time.c

The time.c file feels misplaced here, as it contains a
clocksource/clockevent driver that would normally be placed
in drivers/clocksource.

It's possible that we discussed this before and there was
a reason for keeping it in arch/kvm, but I don't see anything
that prevents it from being built outside of arch/kvx (like
custom instructions that are not defined in a header anywhere).

Can you split that out and submit it as a driver to the
clocksource maintainers, keeping only the time_init()
function in setup.c?

       Arnd