linux-kernel - Re: [PATCH] cgroup: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mbv6jl67qw43ruzf55yzgdo7zrusvuod2c3b7cfgliypyh7pgf@mqneyza5cffr>
Date: Tue, 23 Jul 2024 11:11:35 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: cgroups@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	Johannes Weiner <hannes@...xchg.org>, Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: Use seq_putc() in three functions

Hello.

On Sun, Jul 14, 2024 at 11:33:18AM GMT, Markus Elfring <Markus.Elfring@....de> wrote:
> Single characters should be put into a sequence.
> Thus use the corresponding function “seq_putc”.

seq_puts() handles internally the single char strings already and
calling one function uniformly seems less error prone in general.  I see
only marginal benefit of the change in this context .

> This issue was transformed by using the Coccinelle software.

Maybe that would better fit under scripts/coccinelle/misc for optional
checking.

Thanks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)