linux-kernel - Re: [PATCH v3 6/7] tools: separate out shared radix-tree components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eabb23cf-d142-47d1-b312-b9c7b76015ef@lucifer.local>
Date: Tue, 23 Jul 2024 10:35:43 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Matthew Wilcox <willy@...radead.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, SeongJae Park <sj@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>
Subject: Re: [PATCH v3 6/7] tools: separate out shared radix-tree components

On Tue, Jul 23, 2024 at 12:25:51PM GMT, Mike Rapoport wrote:
> On Mon, Jul 22, 2024 at 12:50:24PM +0100, Lorenzo Stoakes wrote:
> > The core components contained within the radix-tree tests which provide
> > shims for kernel headers and access to the maple tree are useful for
> > testing other things, so separate them out and make the radix tree tests
> > dependent on the shared components.
> >
> > This lays the groundwork for us to add VMA tests of the newly introduced
> > vma.c file.
> >
> > Acked-by: Vlastimil Babka <vbabka@...e.cz>
> > Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > ---
> >  tools/testing/radix-tree/Makefile             | 68 +++----------------
> >  tools/testing/radix-tree/maple.c              | 15 +---
> >  tools/testing/radix-tree/xarray.c             | 10 +--
> >  tools/testing/shared/autoconf.h               |  2 +
> >  tools/testing/{radix-tree => shared}/bitmap.c |  0
> >  tools/testing/{radix-tree => shared}/linux.c  |  0
>
> maybe tools/testing/lib
>
> >  .../{radix-tree => shared}/linux/bug.h        |  0
>
> and tools/testing/include?
>

Right, I was also wondering how best to integrate tools/include (and by
that token, tools/lib) but there are some fiddly include path precedence
tricks used by the various Makefile's that might have made this break
things.

Additionally I think it'd cause some confusion to have tools/include and
tools/testing/include when tools/include is used by a bunch of testing...

So I propose we take a look at seeing if we can't just integrate
tools/include and tools/lib in a follow-up series? (maybe these should
actually be in tools/testing/... too, not sure if there are other tools
that use them as-is).

This one is making a one-shot super conflict-y bunch of changes to mm/ code
I think it's best to get it in asap, it'll be far easier to make changes to
tools/ stuff in isolation later.

>
> --
> Sincerely yours,
> Mike.