linux-kernel - Re: [PATCH v2 2/2] mm: kvmalloc: align kvrealloc() with krealloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240722184348.3df3b433c8f49f123e1c8d9e@linux-foundation.org>
Date: Mon, 22 Jul 2024 18:43:48 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
 iamjoonsoo.kim@....com, vbabka@...e.cz, roman.gushchin@...ux.dev,
 42.hyeyoo@...il.com, urezki@...il.com, hch@...radead.org, kees@...nel.org,
 ojeda@...nel.org, wedsonaf@...il.com, mhocko@...nel.org,
 mpe@...erman.id.au, chandan.babu@...cle.com, christian.koenig@....com,
 maz@...nel.org, oliver.upton@...ux.dev, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mm: kvmalloc: align kvrealloc() with krealloc()

On Mon, 22 Jul 2024 18:29:24 +0200 Danilo Krummrich <dakr@...nel.org> wrote:

> Besides the obvious (and desired) difference between krealloc() and
> kvrealloc(), there is some inconsistency in their function signatures
> and behavior:
> 
>  - krealloc() frees the memory when the requested size is zero, whereas
>    kvrealloc() simply returns a pointer to the existing allocation.

The old kvrealloc() behavior actually sounds somewhat useful.  You've
checked that no existing sites were relying on this?

And that all existing kvrealloc() callers were (incorrectly) checking
for NULL?  Seems that way.