linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zp+AUTAOqc6N7wUr@hu-varada-blr.qualcomm.com>
Date: Tue, 23 Jul 2024 15:35:05 +0530
From: Varadarajan Narayanan <quic_varada@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <gregkh@...uxfoundation.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <quic_wcheng@...cinc.com>,
        <quic_kriskura@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332
 interrupt info

On Thu, Jul 18, 2024 at 08:23:28AM +0200, Krzysztof Kozlowski wrote:
> On 17/07/2024 11:48, Varadarajan Narayanan wrote:
> > IPQ5332 has only three interrupts. Update the constraints
> > to fix the following dt_binding_check errors.
> >
> > 	interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
> >
> > Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding")
> > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > ---
> > v2: Fix patch version numbering. Incorrectly marked the first version as v0
> >     Add interrupts and interrupt-names for ipq5332 instead of clubbing it with
> >     qcom,x1e80100-dwc3
> > ---
> >  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > index 6c5f962bbcf9..5e5cc2175526 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > @@ -235,6 +235,13 @@ allOf:
> >              - const: core
> >              - const: sleep
> >              - const: mock_utmi
> > +        interrupts:
> > +          maxItems: 3
> > +        interrupt-names:
> > +          items:
> > +            - const: pwr_event
> > +            - const: dp_hs_phy_irq
> > +            - const: dm_hs_phy_irq
>
> Why are you duplicating interrupts for this variant? This is
> qcom,ipq6018-dwc3, not 5332. Read carefully how the file is currently
> organized - there is no entry which has clocks and interrupts at one
> place. You are bringing inconsistency, why?

Sorry, something got mixed up while rebasing.
Have posted v3, please take a look.

Thanks
Varada

> >    - if:
> >        properties:
> > @@ -442,7 +449,6 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > -              - qcom,ipq5332-dwc3
> >                - qcom,x1e80100-dwc3
>
> So now 5332 does not have any constraints.
>
> >      then:
> >        properties: