linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: msm8916-wingtech-wt865x8: Add Lenovo A6000/A6010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d982452-f41c-400e-b350-3c022927036c@linaro.org>
Date: Tue, 23 Jul 2024 13:24:37 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Nikita Travkin <nikita@...n.ru>, Bjorn Andersson <andersson@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 Anton Bambura <jenneron@...tmarketos.org>,
 Stephan Gerhold <stephan@...hold.net>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: msm8916-wingtech-wt865x8: Add
 Lenovo A6000/A6010

On 22.07.2024 2:47 PM, Nikita Travkin wrote:
> From: Anton Bambura <jenneron@...tmarketos.org>
> 
> Add initial device-tree for Lenovo A6000 (wt86518) and Lenovo A6010
> (wt86528), which are MSM8916-based devices. These devices are quite
> similar, so some configuration is shared in msm8916-wingtech-wt865x8.dtsi.

[...]


> +/ {
> +	model = "Lenovo A6000 (Wingtech WT86518)";
> +	compatible = "wingtech,wt86518", "qcom,msm8916";
> +	chassis-type = "handset";
> +
> +	speaker_amp: audio-amplifier {
> +		compatible = "awinic,aw8738";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&spk_ext_pa_default>;

flip

[...]

> +&sound {
> +	model = "wt88047";
> +	widgets =
> +		"Speaker", "Speaker",
> +		"Headphone", "Headphones";

Please don't start a new line for this (same below)

> +	pin-switches = "Speaker", "Headphones";
> +	audio-routing =
> +		"Speaker", "Speaker Amp OUT",
> +		"Speaker Amp IN", "HPH_R",

[...]

> +	/* left AW8736 */
> +	speaker_amp_left: audio-amplifier-left {
> +		compatible = "awinic,aw8738";

Should this get a new compatible (with a fallback if sw-compatible)?

> +
> +		pinctrl-0 = <&spk_ext_pa_left_default>;
> +		pinctrl-names = "default";
> +
> +		mode-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>;
> +		sound-name-prefix = "Speaker Amp L";
> +		awinic,mode = <3>;
> +	};
> +
> +	/* right AW8736 */
> +	speaker_amp_right: audio-amplifier-right {
> +		compatible = "awinic,aw8738";

ditto

Konrad