[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAA8EJpqEDqY79pFv_FUH43++BW1iUz3J6sozCEVNfQyQPBjCsw@mail.gmail.com>
Date: Tue, 23 Jul 2024 14:45:58 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Rayyan Ansari <rayyan.ansari@...aro.org>, Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node
On Tue, 23 Jul 2024 at 14:39, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
> On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote:
> > On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote:
> >> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
> >>
> >> Signed-off-by: Rayyan Ansari <rayyan.ansari@...aro.org>
> >> ---
> >> arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
> >> 1 file changed, 9 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> index 2985f4805b93..dbf7afcbfd8b 100644
> >> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> @@ -19,12 +19,16 @@ rtc@...0 {
> >> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> >> };
> >>
> >> - pwrkey@800 {
> >> - compatible = "qcom,pm8941-pwrkey";
> >> + pon@800 {
> >> + compatible = "qcom,pm8941-pon";
> >> reg = <0x800>;
> >> - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> >> - debounce = <15625>;
> >> - bias-pull-up;
> >> +
> >> + pwrkey {
> >> + compatible = "qcom,pm8941-pwrkey";
> >> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> >> + debounce = <15625>;
> >> + bias-pull-up;
> >> + };
> >
> > It might be worth adding the resin node too, see pm8941.dtsi
>
> This is a cleanup series, adding features is another thing and it
> would be nice if somebody could test it
Agreed.
--
With best wishes
Dmitry
Powered by blists - more mailing lists