linux-kernel - Re: [PATCH v2 2/3] memory tiering: introduce folio_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2WXNR4E4LKB.2OILQ9OHM2GQI@nvidia.com>
Date: Tue, 23 Jul 2024 08:55:43 -0400
From: "Zi Yan" <ziy@...dia.com>
To: "David Hildenbrand" <david@...hat.com>, "Lorenzo Stoakes"
 <lorenzo.stoakes@...cle.com>
Cc: "Andrew Morton" <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
 "Huang, Ying" <ying.huang@...el.com>, "Baolin Wang"
 <baolin.wang@...ux.alibaba.com>, "Kefeng Wang"
 <wangkefeng.wang@...wei.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] memory tiering: introduce folio_has_cpupid()
 check

On Tue Jul 23, 2024 at 6:14 AM EDT, David Hildenbrand wrote:
> > 
> > The static version of folio_has_cpupid() is defined in include/linux/mm.h
> > if !CONFIG_NUMA_BALANCING but you define the function in memory-tiers.c
> > unconditionally, a file that is compiled predicated on CONFIG_NUMA.
> > 
> > So a config with !CONFIG_NUMA_BALANCING but CONFIG_NUMA set results in a
> > compilation error (I just hit it this morning in mm-unstable).
> > 
> > A minimal fix for this is to wrap the declaration in:
> > 
> > #ifdef CONFIG_NUMA_BALANCING
> > ...
> > #endif
> > 
> > I've tried this locally and it resolves the issue.

Will fix it. Thanks.

>
> Agreed, with that
>
> Acked-by: David Hildenbrand <david@...hat.com>

Thanks.


-- 
Best Regards,
Yan, Zi


Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)