linux-kernel - Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2024072320-trimness-scribe-8055@gregkh>
Date: Tue, 23 Jul 2024 15:06:03 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: remove unnecessary braces in if
 statements and space before close parenthesis in function call

On Tue, Jul 23, 2024 at 06:28:19PM +0530, Riyan Dhiman wrote:
> Hi,
> 
> Thank you for your feedback on my patch submission.
> I have reviewed the mailing list traffic and noted that the last patch
> addressing the same coding style issue was submitted in April. Given this
> timeframe, I believed it was appropriate to submit my patch to contribute
> to the resolution of the ongoing issue.
> As this is my first contribution to the Linux kernel, I want to ensure that
> my submission aligns with the requirements. I would greatly appreciate your
> guidance on how to improve my patch and avoid duplicating previous efforts.

The issue is that the checkpatch warning for too many () characters is
just not right, and shouldn't be applied for staging fixes, sorry.  The
code is fine as-is.

thanks,

greg k-h