linux-kernel - Re: [PATCH] arm64: dts: s32g: add the pinctrl node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ae43212-2131-41f2-9042-7711efdcfa18@kernel.org>
Date: Tue, 23 Jul 2024 16:57:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>,
 Chester Lin <chester62515@...il.com>, Matthias Brugger <mbrugger@...e.com>,
 Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH] arm64: dts: s32g: add the pinctrl node

On 23/07/2024 15:56, Andrei Stefanescu wrote:
> Hi Krzysztof,
> 
> Thank you for the prompt review!
> 
> On 23/07/2024 16:38, Krzysztof Kozlowski wrote:
>> On 23/07/2024 14:37, Andrei Stefanescu wrote:
>>> +			status = "okay";
>>
>> Where did you disable it?
> 
> It isn't disabled anywhere.

Then what is the point of enabling if it is not disabled?

> I thought we should always have it enabled since most of the
> other drivers will rely on it. Should I add it here disabled and enable it in the
> board specific .dts files (in this case: s32g399a-rdb3.dts, s32g274a-rdb2.dts and
> s32g274a-evb.dts)?

No. I think coding style covers it, please read it.

> 
>>
>>> +
>>> +			jtag_pins: jtag_pins {
>>
>> Underscores are not allowed. Please follow DTS coding style. The
>> mainline one, not NXP coding style. Several other places here have also
>> issues, so be sure you read if carefully.
> 
> Thank you! I will send a V2 with  "jtag_pins: jtag-pins {" and
> all the other subnodes renamed to "jtag-grp*".

Well, fix also other coding style violations...



Best regards,
Krzysztof