linux-kernel - Re: [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7616d1dc-73e9-425e-9a62-1f3b20bec6e9@arm.com>
Date: Tue, 23 Jul 2024 17:05:09 +0100
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>, coresight@...ts.linaro.org,
 gankulkarni@...amperecomputing.com, mike.leach@...aro.org,
 suzuki.poulose@....com
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Ruidong Tian <tianruidong@...ux.alibaba.com>,
 Benjamin Gray <bgray@...ux.ibm.com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf scripts python: cs-etm: Restore first sample log in
 verbose mode

On 7/23/2024 2:28 PM, James Clark wrote:
> 
> The linked commit moved the early return on the first sample to before
> the verbose log, so move the log earlier too. Now the first sample is
> also logged and not skipped.
> 
> Fixes: 2d98dbb4c9c5 ("perf scripts python arm-cs-trace-disasm.py: Do not ignore disam first sample")
> Signed-off-by: James Clark <james.clark@...aro.org>

Reviewed-by: Leo Yan <leo.yan@....com>

> ---
>  tools/perf/scripts/python/arm-cs-trace-disasm.py | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> index d973c2baed1c..7aff02d84ffb 100755
> --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
> +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> @@ -192,17 +192,16 @@ def process_event(param_dict):
>         ip = sample["ip"]
>         addr = sample["addr"]
> 
> +       if (options.verbose == True):
> +               print("Event type: %s" % name)
> +               print_sample(sample)
> +
>         # Initialize CPU data if it's empty, and directly return back
>         # if this is the first tracing event for this CPU.
>         if (cpu_data.get(str(cpu) + 'addr') == None):
>                 cpu_data[str(cpu) + 'addr'] = addr
>                 return
> 
> -
> -       if (options.verbose == True):
> -               print("Event type: %s" % name)
> -               print_sample(sample)
> -
>         # If cannot find dso so cannot dump assembler, bail out
>         if (dso == '[unknown]'):
>                 return
> --
> 2.34.1
>