linux-kernel - Re: [PATCH v2] block: fix deadlock between sd_remove & sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51421cc8-ef09-4d13-ae92-bc0839a8b3b3@acm.org>
Date: Tue, 23 Jul 2024 09:28:27 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yang Yang <yang.yang@...o.com>, Jens Axboe <axboe@...nel.dk>,
 linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] block: fix deadlock between sd_remove & sd_release

On 7/22/24 2:16 AM, Yang Yang wrote:
> SCSI does not set GD_OWNS_QUEUE, so QUEUE_FLAG_DYING is not set in
> this scenario. This is a classic ABBA deadlock. To fix the deadlock,
> make sure we don't try to acquire disk->open_mutex after freezing
> the queue.
> 
> Signed-off-by: Yang Yang <yang.yang@...o.com>

Fixes: and Cc: stable tags are missing. Otherwise this patch looks fine
to me, hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>