linux-kernel - Re: [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86cyn42g65.wl-maz@kernel.org>
Date: Tue, 23 Jul 2024 18:04:34 +0100
From: Marc Zyngier <maz@...nel.org>
To: Sebastian Ott <sebott@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org,
	kvmarm@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Oliver Upton <oliver.upton@...ux.dev>,
	James Morse <james.morse@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build

On Tue, 23 Jul 2024 11:12:01 +0100,
Sebastian Ott <sebott@...hat.com> wrote:
> 
> Building arch/arm64/kvm/ with W=1 spills out a lot of warnings. When
> changing stuff I try to use as much tooling as possible to make sure
> that I don't screw up - having a clean baseline imho helps with that.
> 
> With the first 2 patches applied make W=1 arch/arm64/kvm/ runs without
> warnings for me (fedora userspace, upstream linux after kvm merge).
> Patch 3 gets rid of sparse lock warnings in arch/arm64/kvm/vgic/.
> 
> Patch 1 now just adds -Wno-override-init to the cflags of the affected
> files. Alternatives would be to add this to the whole subdir or
> reintroduce the flag for higher warn levels..
> 
> Sebastian Ott (3):
>   KVM: arm64: fix override-init warnings in W=1 builds
>   KVM: arm64: fix kdoc warnings in W=1 builds
>   KVM: arm64: vgic: fix unexpected unlock sparse warnings
> 
>  arch/arm64/kvm/Makefile          |  3 +++
>  arch/arm64/kvm/arm.c             |  1 +
>  arch/arm64/kvm/hyp/nvhe/Makefile |  2 ++
>  arch/arm64/kvm/hyp/vhe/Makefile  |  2 ++
>  arch/arm64/kvm/vgic/vgic-irqfd.c |  7 ++++---
>  arch/arm64/kvm/vgic/vgic-its.c   | 18 +++++++++++-------
>  arch/arm64/kvm/vgic/vgic-v3.c    |  2 +-
>  arch/arm64/kvm/vgic/vgic.c       |  2 +-
>  arch/arm64/kvm/vgic/vgic.h       |  2 +-
>  9 files changed, 26 insertions(+), 13 deletions(-)

For the series, and assuming we take this in 6.11::

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.