linux-kernel - Re: [PATCH v2] usb: typec: ucsi: Fix NULL pointer dereference in ucsi_displayport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024072350-talisman-elongated-0e3d@gregkh>
Date: Tue, 23 Jul 2024 19:33:21 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ma Ke <make24@...as.ac.cn>
Cc: heikki.krogerus@...ux.intel.com, utkarsh.h.patel@...el.com,
	abhishekpandit@...omium.org, andriy.shevchenko@...ux.intel.com,
	kyletso@...gle.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: typec: ucsi: Fix NULL pointer dereference in
 ucsi_displayport_vdm()

On Tue, Jul 23, 2024 at 10:13:44PM +0800, Ma Ke wrote:
> When dp->con->partner is an error, a NULL pointer dereference may occur.
> Add a check for dp->con->partner to avoid dereferencing a NULL pointer.
> 
> Cc: stable@...r.kernel.org
> Fixes: 372adf075a43 ("usb: typec: ucsi: Determine common SVDM Version")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

How was this found?  How was it tested?  Given that the first version
didn't even build, it seems like this was never tested at all...

thanks,

greg k-h