linux-kernel - Re: [PATCH] mm: list_lru: fix UAF for memory cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nrtjxxhblvuzkv6sytcjay7qr64jozdbp2klipoo2a4ddqe7dp@gufvv4uen76q>
Date: Tue, 23 Jul 2024 10:52:42 -0700
From: Shakeel Butt <shakeel.butt@...ux.dev>
To: Muchun Song <songmuchun@...edance.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, muchun.song@...ux.dev, 
	nphamcs@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: list_lru: fix UAF for memory cgroup

On Thu, Jul 18, 2024 at 04:36:07PM GMT, Muchun Song wrote:
> The mem_cgroup_from_slab_obj() is supposed to be called under rcu
> lock or cgroup_mutex or others which could prevent returned memcg
> from being freed. Fix it by adding missing rcu read lock.
> 
> Fixes: 0a97c01cd20bb ("list_lru: allow explicit memcg and NUMA node selection)
> Signed-off-by: Muchun Song <songmuchun@...edance.com>

Yup I noticed these as well while reviewing Kairui's patches.

Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>