linux-kernel - Re: [RFC PATCH] tty: xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024072322-saucy-silent-626f@gregkh>
Date: Tue, 23 Jul 2024 20:11:37 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: James Minor <jminor1@...nsource.cirrus.com>
Cc: shubhrajyoti.datta@....com, patches@...nsource.cirrus.com,
	jirislaby@...nel.org, michal.simek@....com,
	linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] tty: xilinx_uartps: Fix break detection

On Tue, Jul 23, 2024 at 02:28:58PM +0000, James Minor wrote:
> Commit b8a6c3b3d465 ("tty: xilinx_uartps: Fix the ignore_status")
> used read_status_mask to mask the isrstatus, even though the
> commit appears to be fixing the application of the
> ignore_status_mask.  This has a side effect of clearing any
> pending CDNS_UART_IXR_FRAMING bit, which in turn means that
> cdns_uart_handle_rx break detection will only process framing
> errors when parity is enabled (INPCK set via
> cdns_uart_set_termios).
> 
> Fix this by removing the extra isrstatus masking with
> read_status_mask, which still allows the ignore_status_mask to be
> applied.
> 
> Fixes: b8a6c3b3d465 ("tty: xilinx_uartps: Fix the ignore_status")
> Signed-off-by: James Minor <jminor1@...nsource.cirrus.com>
> ---
> 
> The other alternative to this would be a straight revert of
> b8a6c3b3d465, since read_status_mask and ignore_status_mask are
> both applied in cnds_uart_handle_rx anyway.  Let me know the
> preference here and I will change accordingly.
> 
>  drivers/tty/serial/xilinx_uartps.c | 1 -
>  1 file changed, 1 deletion(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot