linux-kernel - Re: [PATCH] lib: bitmap: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9fbff19-2ace-44d5-99d1-6df759cd45d1@quicinc.com>
Date: Tue, 23 Jul 2024 11:47:08 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Yury Norov <yury.norov@...il.com>
CC: Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andrew Morton
	<akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros

On 5/31/2024 8:08 PM, Yury Norov wrote:
> On Fri, May 31, 2024 at 09:03:11AM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>> This is the subset of "missing MODULE_DESCRIPTION()" which fall under
>> the scope of the BITMAP API entry in the MAINTAINERS file.
>> ---
>>  lib/cpumask_kunit.c      | 1 +
>>  lib/find_bit_benchmark.c | 1 +
>>  lib/test_bitmap.c        | 1 +
>>  3 files changed, 3 insertions(+)
>>
>> diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
>> index a105e6369efc..6b62a6bdd50e 100644
>> --- a/lib/cpumask_kunit.c
>> +++ b/lib/cpumask_kunit.c
>> @@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
>>  };
>>  kunit_test_suite(test_cpumask_suite);
>>  
>> +MODULE_DESCRIPTION("KUnit tests for cpumask");
>>  MODULE_LICENSE("GPL");
>> diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
>> index d3fb09e6eff1..402e160e7186 100644
>> --- a/lib/find_bit_benchmark.c
>> +++ b/lib/find_bit_benchmark.c
>> @@ -194,4 +194,5 @@ static int __init find_bit_test(void)
>>  }
>>  module_init(find_bit_test);
>>  
>> +MODULE_DESCRIPTION("Test for find_*_bit functions");
>>  MODULE_LICENSE("GPL");
>> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
>> index 6dfb8d46a4ff..65a75d58ed9e 100644
>> --- a/lib/test_bitmap.c
>> +++ b/lib/test_bitmap.c
>> @@ -1486,4 +1486,5 @@ static void __init selftest(void)
>>  
>>  KSTM_MODULE_LOADERS(test_bitmap);
>>  MODULE_AUTHOR("david decotigny <david.decotigny@...glers.com>");
>> +MODULE_DESCRIPTION("Test cases for bitmap API");
>>  MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
>> change-id: 20240531-lib-bitmap-7ce67db2d173
> 
> Applied in bitmap-for-next.

Hi,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff