linux-kernel - Re: [PATCH v3] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4ac0022-5ba4-44b9-ac09-4530a18b0974@arm.com>
Date: Tue, 23 Jul 2024 22:47:22 +0200
From: Dietmar Eggemann <dietmar.eggemann@....com>
To: Chuyi Zhou <zhouchuyi@...edance.com>, mingo@...hat.com,
 peterz@...radead.org, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 rostedt@...dmis.org, bsegall@...gle.com
Cc: chengming.zhou@...ux.dev, linux-kernel@...r.kernel.org,
 Vishal Chourasia <vishalc@...ux.ibm.com>,
 K Prateek Nayak <kprateek.nayak@....com>
Subject: Re: [PATCH v3] sched/fair: Remove cfs_rq::nr_spread_over and
 cfs_rq::exec_clock

On 20/07/2024 05:19, Chuyi Zhou wrote:
> nr_spread_over tracks the number of instances where the difference
> between a scheduling entity's virtual runtime and the minimum virtual
> runtime in the runqueue exceeds three times the scheduler latency,
> indicating significant disparity in task scheduling.
> Commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") removed its usage.
> 
> cfs_rq->exec_clock was used to account for time spent executing tasks.
> Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
> removed its usage.

I was under the impression this commit removed
'schedstat_add(cfs_rq->exec_clock, delta_exec)' from update_curr() by
mistake?

That's why I sent out this patch back in May:

https://lkml.kernel.org/r/20240503104605.1871571-1-dietmar.eggemann@arm.com

to add it back.