linux-kernel - Re: [GIT PULL] Kbuild updates for v6.11-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiF3yeWehcvqY-4X7WNb8n4yw_5t0H1CpEpKi7JMjaMfw@mail.gmail.com>
Date: Tue, 23 Jul 2024 14:49:05 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Kbuild updates for v6.11-rc1

On Tue, 23 Jul 2024 at 12:44, Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> You will get a merge conflict in scripts/Makefile.lib

So the merge conflict certainly wasn't too bad, but I really don't
love the complex  fdtoverlay command duplication.

Strangely enough, there's a simplification for the DT_CHECK_CMD case
(used only once), but not for this creation case (now duplicate).

I didn't do it as part of the merge, but may I suggest adding something like

  DT_CREATE_CMD = $(objtree)/scripts/dtc/fdtoverlay -i $(filter %.dtb
%.dtbo, $^) -o

and then using

   $(DT_CREATE_CMD) $@

to pair up with the existing "$(DT_CHECK_CMD) $@" logic?

Or something along those lines?

(And no, I didn't check whether maybe the argument order for the
'fdtoverlay' script might matter, or something like that - I don't
think it does, but I did *not* test the above suggestion or really try
to think about it deeply, just mostly a reaction against the command
duplication particularly when there is now a comment about the
subtlety of the arguments)

             Linus