linux-kernel - Re: [RESEND PATCH v2] selftests:Fix printf format string in kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOsKWHArGK0yVhQSNN1nmcYvxSpsjV21L38XkAvdVGNcJ1xkAA@mail.gmail.com>
Date: Wed, 24 Jul 2024 10:47:47 +0800
From: Chunyan Zhang <zhang.lyra@...il.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: shuah@...nel.org, kees@...nel.org, luto@...capital.net, wad@...omium.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] selftests:Fix printf format string in kselftest_harness.h

Hi Zhu Jun,

On Wed, 24 Jul 2024 at 10:15, Zhu Jun <zhujun2@...s.chinamobile.com> wrote:
>
> '%u' in format string requires 'unsigned int' in __wait_for_test()
> but the argument type is 'signed int' that this problem was discovered
> by reading code
>
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
> Changes in v2:
>  - modify commit info add how to find the problem in the log
>
>  tools/testing/selftests/kselftest_harness.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index b634969cbb6f..dbbbcc6c04ee 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -1084,7 +1084,7 @@ void __wait_for_test(struct __test_metadata *t)
>                 }
>         } else {
>                 fprintf(TH_LOG_STREAM,
> -                       "# %s: Test ended in some other way [%u]\n",
> +                       "# %s: Test ended in some other way [%d]\n",
>                         t->name,
>                         status);

Seems this can use macro WTERMSIG like those above usage, rather than
changing the print format.

Thanks,
Chunyan