linux-kernel - Re: [PATCH] iommu: arm-smmu: Fix Tegra workaround for PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <660afec5-d8d6-4cc3-a236-85d98aaad7ff@nvidia.com>
Date: Wed, 24 Jul 2024 10:22:22 +0530
From: Ashish Mhetre <amhetre@...dia.com>
To: Will Deacon <will@...nel.org>
Cc: thierry.reding@...il.com, vdumpa@...dia.com, robin.murphy@....com,
 joro@...tes.org, linux-tegra@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: arm-smmu: Fix Tegra workaround for PAGE_SIZE
 mappings


On 7/23/2024 9:41 PM, Will Deacon wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Jul 17, 2024 at 07:21:45AM +0000, Ashish Mhetre wrote:
>> PAGE_SIZE can be 16KB for Tegra which is not supported by MMU-500 on
>> both Tegra194 and Tegra234. So, use 4KB mappings when PAGE_SIZE is 16KB.
>>
>> Signed-off-by: Ashish Mhetre <amhetre@...dia.com>
>> ---
>>   drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c b/drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c
>> index 4b2994b6126d..bb621a94f6fe 100644
>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c
>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c
>> @@ -273,11 +273,12 @@ static int nvidia_smmu_init_context(struct arm_smmu_domain *smmu_domain,
>>         * release of PMD entry and avoid translations seeing stale PMD entry in
>>         * walk cache.
>>         * Fix this by limiting the page mappings to PAGE_SIZE on Tegra194 and
>> -      * Tegra234.
>> +      * Tegra234. Use 4K page mappings if PAGE_SIZE is 16K as MMU500 doesn't
>> +      * support it.
>>         */
>>        if (of_device_is_compatible(np, "nvidia,tegra234-smmu") ||
>>            of_device_is_compatible(np, "nvidia,tegra194-smmu")) {
>> -             smmu->pgsize_bitmap = PAGE_SIZE;
>> +             smmu->pgsize_bitmap = (PAGE_SIZE == SZ_16K) ? SZ_4K : PAGE_SIZE;
> Perhaps it would be more robust to do a read-modify-write of the
> pgsize_bitmap, preserving all the page-sizes that are <= PAGE_SIZE (i.e.
> and it with something like GENMASK(PAGE_SHIFT, 0)?
>
> Will


Thanks for the review Will. Yes, that will be a better approach as
pgsize_bitmap will never be with 16K granularity for Tegra.
I will send new version with this update.