linux-kernel - Re: [PATCH] scripts: add macro_checker script to check unused parameters in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240723220359.e96522515469210f5a420aab@linux-foundation.org>
Date: Tue, 23 Jul 2024 22:03:59 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Julian Sun <sunjunchao2870@...il.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, jack@...e.cz, brauner@...nel.org,
 viro@...iv.linux.org.uk, masahiroy@...nel.org, n.schier@....de,
 ojeda@...nel.org, djwong@...nel.org, kvalo@...nel.org
Subject: Re: [PATCH] scripts: add macro_checker script to check unused
 parameters in macros

On Tue, 23 Jul 2024 23:03:53 -0400 Julian Sun <sunjunchao2870@...il.com> wrote:

> > > "make help | grep check" shows we have a few ad-hoc integrations but I
> > > wonder if we would benefit from a top-level `make static-checks'
> > > target?
> I have another idea. I asked some of my friends,  they are familiar
> with scripts/checkpatch.pl and usually use it to check patches before
> submitting them. Therefore, can we integrate some checking tools like
> includecheck and macro_checker into checkpatch?

Well, checkpatch is for checking patches - it will check whole files
but isn't typically used that way as far as I know.

A higher-level script which bundles the various static checking tools
would be the way to go.