linux-kernel - Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: Add support for Amlogic Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee98ce34-a08b-4aa1-aa16-d3539460c396@amlogic.com>
Date: Wed, 24 Jul 2024 14:48:48 +0800
From: Yang Li <yang.li@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: Add support for
 Amlogic Bluetooth

On 2024/7/22 15:58, Krzysztof Kozlowski wrote:
> On 22/07/2024 09:41, Yang Li wrote:
>>>>>> +    description: bluetooth chip 3.3V supply regulator handle
>>>>>> +
>>>>>> +  clocks:
>>>>>> +    maxItems: 1
>>>>>> +    description: clock provided to the controller (32.768KHz)
>>>>>> +
>>>>>> +  antenna-number:
>>>>>> +    default: 1
>>>>>> +    description: device supports up to two antennas
>>>>> Keep it consistent - either descriptions are the last property or
>>>>> somewhere else. Usually the last.
>>>>>
>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> And what does it mean? What happens if BT uses antenna number 2, not 1?
>>>>> What is connected to the other antenna? It really feels useless to say
>>>>> which antenna is connected to hardware.
>>>> Sorry, the antenna description was incorrect, it should specify whether
>>>>
>>>> Bluetooth and WiFi coexist. I will change it as below:
>>>>
>>>>        aml,work-mode:
>>>>        type: boolean
>>>>        description: specifywhether Bluetooth and WiFi coexist.
>>> So one device can be used on different boards - some without WiFi
>>> antenna? But, why in the binding of bluetooth you describe whether there
>>> is WiFi antenna?
>> Yes, it can be used on dirfferent boards. The device can operate in both
> Please do not respond to only partial part of the comment. It is obvious
> device can work on different boards. You do not have to confirm it. The
> question was different - why do you need this property? I gave you
> possible answer, but you skipped this and answered with obvious statement.

I'm sorry. I didn't explain it clearly.

Board design should be optimized for specific use cases: use the 
standalone mode for high-speed, stable, and Bluetooth-only applications; 
opt for the coexistence mode in cost-sensitive scenarios with lower 
performance demands. Once the hardware is determined, the user needs to 
configure the working mode of the firmware.

>
>> standalone mode and coexistence mode. typically running standalone mode.
>>
>> Therefore, I would like to revise the description as follows:
>>
>> aml,coexisting:
>>       type: boolean
>>       description: Enable coexistence mode, allowing shared antenna usage
>> with Wi-Fi.
> Why this is not enabled always?

The board design determines whether to enable this property.

Well, I know I should clearly describe why this property is enabled 
here, so I modify it as follows:

aml,coexisting:
      type: boolean
      description: Enable co-existence mode on boards sharing antennas 
with Wi-Fi.

>
> Best regards,
> Krzysztof
>