linux-kernel - RE: [PATCH v2] exfat: check disk status during buffer write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1625601dadd97$88eca020$9ac5e060$@samsung.com>
Date: Wed, 24 Jul 2024 16:03:06 +0900
From: "Sungjong Seo" <sj1557.seo@...sung.com>
To: "'Dongliang Cui'" <dongliang.cui@...soc.com>, <linkinjeon@...nel.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc: <niuzhiguo84@...il.com>, <hao_hao.wang@...soc.com>,
	<ke.wang@...soc.com>, <cuidongliang390@...il.com>, "'Zhiguo Niu'"
	<zhiguo.niu@...soc.com>, <sj1557.seo@...sung.com>
Subject: RE: [PATCH v2] exfat: check disk status during buffer write

> We found that when writing a large file through buffer write, if the
> disk is inaccessible, exFAT does not return an error normally, which
> leads to the writing process not stopping properly.
> 
> To easily reproduce this issue, you can follow the steps below:
> 
> 1. format a device to exFAT and then mount (with a full disk erase)
> 2. dd if=/dev/zero of=/exfat_mount/test.img bs=1M count=8192
> 3. eject the device
> 
> You may find that the dd process does not stop immediately and may
> continue for a long time.
> 
> The root cause of this issue is that during buffer write process,
> exFAT does not need to access the disk to look up directory entries
> or the FAT table (whereas FAT would do) every time data is written.
> Instead, exFAT simply marks the buffer as dirty and returns,
> delegating the writeback operation to the writeback process.
> 
> If the disk cannot be accessed at this time, the error will only be
> returned to the writeback process, and the original process will not
> receive the error, so it cannot be returned to the user side.
> 
> When the disk cannot be accessed normally, an error should be returned
> to stop the writing process.
> 
> Signed-off-by: Dongliang Cui <dongliang.cui@...soc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>
> ---
> Changes in v2:
>  - Refer to the block_device_ejected in ext4 for determining the
>    device status.
>  - Change the disk_check process to exfat_get_block to cover all
>    buffer write scenarios.
> ---
> ---
>  fs/exfat/inode.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c
> index dd894e558c91..463cebb19852 100644
> --- a/fs/exfat/inode.c
> +++ b/fs/exfat/inode.c
> @@ -8,6 +8,7 @@
>  #include <linux/mpage.h>
>  #include <linux/bio.h>
>  #include <linux/blkdev.h>
> +#include <linux/backing-dev-defs.h>
>  #include <linux/time.h>
>  #include <linux/writeback.h>
>  #include <linux/uio.h>
> @@ -275,6 +276,13 @@ static int exfat_map_new_buffer(struct
> exfat_inode_info *ei,
>  	return 0;
>  }
> 
> +static int exfat_block_device_ejected(struct super_block *sb)
> +{
> +	struct backing_dev_info *bdi = sb->s_bdi;
> +
> +	return bdi->dev == NULL;
> +}
Have you tested with this again?

> +
>  static int exfat_get_block(struct inode *inode, sector_t iblock,
>  		struct buffer_head *bh_result, int create)
>  {
> @@ -290,6 +298,9 @@ static int exfat_get_block(struct inode *inode,
> sector_t iblock,
>  	sector_t valid_blks;
>  	loff_t pos;
> 
> +	if (exfat_block_device_ejected(sb))
This looks better than the modified location in the last patch.
However, the caller of this function may not be interested in exfat
error handling, so here we should call exfat_fs_error_ratelimit()
with an appropriate error message.

> +		return -ENODEV;
> +
>  	mutex_lock(&sbi->s_lock);
>  	last_block = EXFAT_B_TO_BLK_ROUND_UP(i_size_read(inode), sb);
>  	if (iblock >= last_block && !create)
> --
> 2.25.1