linux-kernel - Re: [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b970471-114e-4955-811d-592c12b1782f@linaro.org>
Date: Wed, 24 Jul 2024 09:54:32 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Conor Dooley <conor@...nel.org>, Hironori KIKUCHI <kikuchan98@...il.com>
Cc: linux-kernel@...r.kernel.org, Jagan Teki <jagan@...rulasolutions.com>,
 Jessica Zhang <quic_jesszhan@...cinc.com>, Sam Ravnborg <sam@...nborg.org>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX
 panel

Hi,

On 10/07/2024 16:01, Conor Dooley wrote:
> On Sat, Jul 06, 2024 at 07:23:34PM +0900, Hironori KIKUCHI wrote:
>> The RG28XX panel is a display panel of the Anbernic RG28XX, a handheld
>> gaming device from Anbernic. It is 2.8 inches in size (diagonally) with
>> a resolution of 480x640.
>>
>> This panel is driven by a variant of the ST7701 driver IC internally,
>> confirmed by dumping and analyzing its BSP initialization sequence
>> by using a logic analyzer. It is very similar to the existing
>> densitron,dmt028vghmcmi-1a panel, but differs in some unknown
>> register values, so add a new entry for the panel to distinguish them.
>>
>> Additionally, the panel only has an SPI instead of MIPI DSI.
>> So add and modify for SPI as well.
>>
>> Signed-off-by: Hironori KIKUCHI <kikuchan98@...il.com>
> 
> With a mention in the commit message about why we are adding a property
> and then immediately forbidding its use:
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Can you resend a v4 with this suggestion ?

Thanks,
Neil

> 
> Thanks,
> Conor.