lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f691d555-839c-4f80-9097-eac27823a35c@kernel.org>
Date: Wed, 24 Jul 2024 09:59:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Potin Lai <potin.lai.pt@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>,
 Patrick Williams <patrick@...cx.xyz>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 Cosmo Chou <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC

On 24/07/2024 09:41, Potin Lai wrote:
> Add linux device tree entry for Meta(Facebook) Catalina compute-tray
> BMC using AT2600 SoC.
> 
> Signed-off-by: Potin Lai <potin.lai@...ntatw.com>

Thank you for your patch. There is something to discuss/improve.

> +		i2c1mux0ch4: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x4>;
> +
> +			power-monitor@42 {
> +				compatible = "lltc,ltc4287";
> +				reg = <0x42>;
> +				shunt-resistor-micro-ohms = <200>;
> +			};
> +			power-monitor@43 {
> +				compatible = "lltc,ltc4287";
> +				reg = <0x43>;
> +				shunt-resistor-micro-ohms = <200>;
> +			};
> +		};
> +		i2c1mux0ch5: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x5>;
> +
> +			// PDB FRU EEPROM
> +			eeprom@54 {
> +				compatible = "atmel,24c64";
> +				reg = <0x54>;
> +			};
> +
> +			// PDB TEMP SENSOR
> +			tmp75@4f {

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation



Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ