linux-kernel - Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ccf3891-fd72-47de-ab89-cdc7e9425c56@web.de>
Date: Wed, 24 Jul 2024 11:30:50 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 Ilia Mirkin <imirkin@...m.mit.edu>, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org
Cc: Daniel Vetter <daniel@...ll.ch>, Danilo Krummrich <dakr@...hat.com>,
 David Airlie <airlied@...il.com>, Karol Herbst <kherbst@...hat.com>,
 Lyude Paul <lyude@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/debugfs: Simplify character output in
 nouveau_debugfs_vbios_image()

>> Is there some reason this whole thing isn't just
>>
>> seq_write(m, drm->vbios.data, drm->vbios.length)
…
> I don't know if my answer is relevant or not here but:
>     for () seq_putc();    ==> will fill 'm' with everything that fits in

I find such a discussion approach strange.


> and
>     seq_write()        ==> is all or nothing. So if 'm' is too small, then nothing will be appended.

The clarification can become more interesting for this system detail.
https://elixir.bootlin.com/linux/v6.10/source/fs/seq_file.c#L816

Was the sequence size (or the file capacity) appropriately configured?

Regards,
Markus