linux-kernel - Re: [PATCH][next] drm/i915/dp: Make read-only array bw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frrzf6kb.fsf@intel.com>
Date: Wed, 24 Jul 2024 13:05:56 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Colin Ian King <colin.i.king@...il.com>, Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/i915/dp: Make read-only array bw_gbps static
 const

On Mon, 22 Jul 2024, Colin Ian King <colin.i.king@...il.com> wrote:
> Don't populate the read-only array bw_gbps on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 59f11af3b0a1..a082ed8f5464 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3434,7 +3434,7 @@ static void intel_dp_get_pcon_dsc_cap(struct intel_dp *intel_dp)
>  
>  static int intel_dp_pcon_get_frl_mask(u8 frl_bw_mask)
>  {
> -	int bw_gbps[] = {9, 18, 24, 32, 40, 48};
> +	static const int bw_gbps[] = {9, 18, 24, 32, 40, 48};
>  	int i;
>  
>  	for (i = ARRAY_SIZE(bw_gbps) - 1; i >= 0; i--) {

-- 
Jani Nikula, Intel